On Mon, Dec 6, 2021 at 1:38 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > On 12/5/21 3:59 PM, Linus Walleij wrote: > > There is no need to allocate the state container and look > > up DT properties in a separate function if OF is all we > > support. Inline it into probe(). > > > > This is POV. Old fashioned as I am, I still prefer smaller > functions over large ones. Is there a _technical_ reason > for this change ? Mainly the *data state container should be allocated in probe() but I can keep the rest in a separate (renamed, moved) function, I can certainly respin it like such, just a minute! Yours, Linus Walleij