On Fri, Dec 3, 2021 at 10:02 PM Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> wrote: > I wonder if this will ever be used by any other driver. Having > multiple maintanence states seems to be very specific to the > ab8500 driver stack. It's actually coming from Samsung and their way of dealing with their Li-Ion batteries. They even have further charging states... Like starting the charge with slightly higher current etc. > But the code itself looks ok and considering > this does not expose any (potentially unfixable) userspace ABI > and improves the AB8500 mess I'm fine with it. I will rebase this patch before the NTC things and send it separately so it can be applied. It will better to first merge the pointer passing change I iterated though, so I'll wait a bit so we can agree to merge that. https://lore.kernel.org/linux-pm/20211206000651.4168035-1-linus.walleij@xxxxxxxxxx/ Yours, Linus Walleij