On Thu, Nov 25, 2021 at 10:05 PM Eugene Shalygin <eugene.shalygin@xxxxxxxxx> wrote: > > On Thu, 25 Nov 2021 at 20:54, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > We won't be heving two drivers with the same functionality. Give me one > > reason why I should not drop the wmi driver (or both of them; I am not > > sure which one we are talking about here). > > > > On top of all that, this submission isn't about any of the wmi drivers, > > but for the nct6775 driver, which just adds to the confusion. > > Let me try to explain once again, please. I began to dig into the ASUS > sensors and how to read their values and at first found the WMI > function to do that, wrote a driver and Denis submitted it as > asus_wmi_ec_sensors. Now, I know a better and simpler way to read > those sensors, which uses ACPI mutex directly. I suggested Denis to > use the mutex way for the nct6775 driver for motherboards without WMI > functions to read from the nct chip. With that change entering the nct > driver, I want to submit my updated driver for EC sensors, replacing > the asus_wmi_ec_sensors code (which is essentially my old driver). > > So, now I ask to rename asus_wmi_sensors to asus_ec_sensors (source > file and KBuild options) already before 5.16 is released, because the > updated code, which I will submit later, and which will replace that > in asus_wmi_ec_sensors.c, does not use WMI. > > Hope this clarifies my request and intention. Since you are talking about something which is not ready yet (as I read "will" above), I propose a compromise variant, i.e. let's leave current driver(s) as is for v5.17 and after v5.17-rc1 you submit your proposal for review. Okay? -- With Best Regards, Andy Shevchenko
