On 11/23/21 1:52 PM, Moger, Babu wrote:
On 11/23/2021 3:40 PM, Guenter Roeck wrote:
On 11/23/21 1:16 PM, Babu Moger wrote:
It seems appropriate to move the CCD specific information inside the
k10temp_data structure.
Why ? I don't see it used outside k10temp_get_ccd_support().
Thought it will be cleaner to have it all together at one structure. If
you feel otherwise I can remove it.
I don't see the point of having a value in a data structure that isn't
used anywhere outside probing but nevertheless lives forever.
I also don't see how it is "cleaner" to assign a value to a variable
in a data structure only to dereference it in a single called function,
when it can be just as easily be passed as argument to that function.
I would call that just the opposite, since it creates the impression
that the variable is needed outside probing when that is not the case.
Guenter
