On Sat, 2021-11-20 at 13:51 -0800, Guenter Roeck wrote: > On Sat, Nov 20, 2021 at 02:36:39PM -0700, David Mosberger-Tang wrote: > > On Sat, 2021-11-20 at 13:12 -0800, Guenter Roeck wrote: > > > On 11/20/21 12:40 PM, David Mosberger-Tang wrote: > > > > This patch enables automatic loading of the sht4x module via a device > > > > tree table entry. > > > > > > > > Signed-off-by: David Mosberger-Tang <davidm@xxxxxxxxxx> > > > > --- > > > > .../bindings/hwmon/sensirion,sht4x.yaml | 50 +++++++++++++++++++ > > > > drivers/hwmon/sht4x.c | 7 +++ > > > > > > This needs to be two separate patches, one the devicetree change and the other > > > the source code change. DT maintainers need to be copied on the devicetree > > > patch. > > > > Isn't that going to be confusing if one but not the other patch makes > > it into a repository? Either you end up with an undocumented device > > tree property or you end up with documentation for an unsupported > > property. > > > This is a trivial device, so that isn't really an issue. Otherwise, > if there are real bindings to approve, I would not accept the patch > making the code change unless the devicetree patch is approved, > and I would typically apply both together. Got it, thanks for the explanation. --david
