Re: [PATCH 4/5] hwmon: (dell-smm) Add Dell Inspiron 3505 config data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 21.10.21 um 20:05 schrieb Pali Rohár:
On Thursday 21 October 2021 19:54:46 W_Armin@xxxxxx wrote:
From: Armin Wolf <W_Armin@xxxxxx>

After checking the fan speeds reported with the
Dell Diag UEFI ROM, its safe to permanently
set fan_max to I8K_FAN_HIGH and fan_mult
to 1 for the Dell Inspiron 3505.

Tested on a Dell Inspiron 3505.
Hello! Are there any issues without this change on Dell Inspiron 3505?
Because i8k_config_data[] array is there for machines which need some
hooks and do not work correctly (e.g. allowing to use I8K_FAN_TURBO).
The Inspiron 3505 works fine without this change. If i8k_config_data[]
is only there for applying
device specific quirks, then this change can be removed.
Signed-off-by: Armin Wolf <W_Armin@xxxxxx>
---
  drivers/hwmon/dell-smm-hwmon.c | 13 +++++++++++++
  1 file changed, 13 insertions(+)

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 5f0338b4a717..2579dd646b20 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -990,6 +990,7 @@ struct i8k_config_data {
  };

  enum i8k_configs {
+	DELL_INSPIRON_3505,
  	DELL_LATITUDE_D520,
  	DELL_PRECISION_490,
  	DELL_STUDIO,
@@ -997,6 +998,10 @@ enum i8k_configs {
  };

  static const struct i8k_config_data i8k_config_data[] __initconst = {
+	[DELL_INSPIRON_3505] = {
+		.fan_mult = 1,
+		.fan_max = I8K_FAN_HIGH,
+	},
  	[DELL_LATITUDE_D520] = {
  		.fan_mult = 1,
  		.fan_max = I8K_FAN_TURBO,
@@ -1030,6 +1035,14 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
  			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude"),
  		},
  	},
+	{
+		.ident = "Dell Inspiron 3505",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 3505"),
+		},
+		.driver_data = (void *)&i8k_config_data[DELL_INSPIRON_3505],
+	},
  	{
  		.ident = "Dell Inspiron 2",
  		.matches = {
--
2.20.1






[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux