Re: [PATCH v3 1/2] hwmon: (dell-smm) Add support for fanX_min, fanX_max and fanX_target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/16/21 3:09 PM, Armin Wolf wrote:
Am 17.10.21 um 00:00 schrieb Guenter Roeck:
On 10/16/21 2:25 PM, Armin Wolf wrote:
Am 13.10.21 um 20:51 schrieb Guenter Roeck:
On Mon, Sep 27, 2021 at 12:10:43AM +0200, W_Armin@xxxxxx wrote:
From: Armin Wolf <W_Armin@xxxxxx>

The nominal speed of each fan can be obtained with
i8k_get_fan_nominal_speed(), however the result is not available
from userspace.
Change that by adding fanX_min, fanX_max and fanX_target attributes.
All are RO since fan control happens over pwm.

Tested on a Dell Inspiron 3505 and a Dell Latitude C600.

Signed-off-by: Armin Wolf <W_Armin@xxxxxx>
Reviewed-by: Pali Rohár <pali@xxxxxxxxxx>
Applied.


[ ... ]

After looking at hwmon-next today, i noticed that this patch was
apparently removed.
Is there a issue with this patch causing the revert?

Not that I recall. Looks like I messed up. Sorry, and thanks for
noticing.
I added it back in.

Guenter
It seems its not the only patch missing, i cant find the following
patches anymore:

[PATCH v2] hwmon: acpi_power_meter: Use acpi_bus_get_acpi_device()
[PATCH v2 04/20 hwmon: max31722: Warn about failure to put device in
stand-by in .remove()

You are right. I added them back in. Must have had a blackout or something :-(.

Thanks a lot for checking!

Guenter



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux