> > Please align continuation lines with "(". > Oh, even if that would result in a lot of extra lines? Or just start > the first argument on a new line? > > space around '-' > Oh yeah, I'm sorry. Is there a code formatter I should have run? I did > run "checkpatch.pl", hoping that it would catch those. > > Unnecessary continuation lines. There are several more of those; > > I won't comment on it further. Please only use continuation lines if > > the resulting line length is otherwise > 100 columns. > Argh, yeah. After refactoring that function, I thought I caught all of > them, but obviously I didn't. According to [1] we should stay within > 80 columns (and use tabs that are 8 spaces wide). I assume that still > applies? The rest of this code follows that rule. For all of the above: I found that running clang-format within subl for the new code does what we want. Sorry again for that, I'll start doing that from now. Oskar.