Re: [PATCH v3 04/11] hwmon: (tmp421) add support for defining labels from DT

[Krzysztof Adamski <krzysztof.adamski@xxxxxxxxx>]

Dnia Sat, Oct 02, 2021 at 07:08:39AM -0700, Guenter Roeck napisał(a):
> > @@ -286,9 +299,53 @@ static int tmp421_detect(struct i2c_client *client,
> >  	return 0;
> >  }
> >
> > +static int tmp421_probe_child_from_dt(struct i2c_client *client,
> > +				      struct device_node *child,
> > +				      struct tmp421_data *data)
> > +
> > +{
> > +	struct device *dev = &client->dev;
> > +	u32 i;
> > +	int err;
> > +
> > +	err = of_property_read_u32(child, "reg", &i);
> > +	if (err) {
> > +		dev_err(dev, "missing reg property of %pOFn\n", child);
> > +		return err;
> > +	}
> > +
> > +	if (i > MAX_CHANNELS) {
>
> I think this needs to be >=. MAX_CHANNELS is 4, the array size
> is 4, and i == 4 will write after the end of the array.

You are absoluetly right here. Off by one error. I will fix this in v4.

Krzysztof