On Mon, Sep 20, 2021 at 08:41:18PM +0300, Vadim Pasternak wrote:
> Fix counter limit in 'for' loop in mlxreg_fan_cooling_config().
> The issue found in the report on new defect(s) introduced to linux-next
> weekly scan found with Coverity Scan - memory access violation.
>
> ** CID 1507571: Memory - illegal accesses (OVERRUN)
> /drivers/hwmon/mlxreg-fan.c: 560 in mlxreg_fan_cooling_config()
>
> >>> Overrunning array of 160 bytes at byte offset 160 by dereferencing
> pointer "pwm".
>
> Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxx>
I just applied a similar patch. I added you as Reported-by: to that patch.
Thanks,
Guenter
> ---
> drivers/hwmon/mlxreg-fan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/mlxreg-fan.c b/drivers/hwmon/mlxreg-fan.c
> index 35228ed112d7..feab9ec6a6ca 100644
> --- a/drivers/hwmon/mlxreg-fan.c
> +++ b/drivers/hwmon/mlxreg-fan.c
> @@ -554,7 +554,7 @@ static int mlxreg_fan_cooling_config(struct device *dev, struct mlxreg_fan *fan)
> {
> int i, j;
>
> - for (i = 0; i <= MLXREG_FAN_MAX_PWM; i++) {
> + for (i = 0; i < MLXREG_FAN_MAX_PWM; i++) {
> struct mlxreg_fan_pwm *pwm = &fan->pwm[i];
>
> if (!pwm->connected)
