On Tue, Sep 14, 2021 at 04:35:43PM -0500, Eddie James wrote: > Save any FFDC provided by the OCC driver, and provide it to userspace > through a binary sysfs entry. Do some basic state management to > ensure that userspace can always collect the data if there was an > error. Notify polling userspace when there is an error too. > > Signed-off-by: Eddie James <eajames@xxxxxxxxxxxxx> > --- > drivers/hwmon/occ/p9_sbe.c | 98 +++++++++++++++++++++++++++++++++++++- > 1 file changed, 97 insertions(+), 1 deletion(-) You forgot a Documentation/ABI/ entry :( Binary sysfs files are for "pass through to the hardware" only, you should not be dumping kernel data to userspace through them. I can't really determine if this is the case here or not, as there's no documentation saying what you are trying to represent here... thanks, greg k-h
