On Fri, Sep 10, 2021 at 9:19 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> When CONFIG_PROC_FS is not set, there is a build warning (turned
> into an error):
>
> ../drivers/hwmon/dell-smm-hwmon.c: In function 'i8k_init_procfs':
> ../drivers/hwmon/dell-smm-hwmon.c:624:24: error: unused variable 'data' [-Werror=unused-variable]
> struct dell_smm_data *data = dev_get_drvdata(dev);
>
> Fix this by making I8K depend on PROC_FS and HWMON (instead of
> selecting HWMON -- we prefer and try hard not to select entire
> subsystems).
>
> Build tested in all possible combinations of SENSORS_DELL_SMM,
> I8K, and PROC_FS.
>
> Fixes: 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Pali Rohár <pali@xxxxxxxxxx>
> Cc: Jean Delvare <jdelvare@xxxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: linux-hwmon@xxxxxxxxxxxxxxx
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: x86@xxxxxxxxxx
> Cc: Armin Wolf <W_Armin@xxxxxx>
I submitted a different patch today after noticing the same issue but
your patch is better:
Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
Arnd
