On Mon, Sep 20, 2021 at 03:14:40PM +0200, Arnd Bergmann wrote: > On Mon, Sep 20, 2021 at 2:31 PM Pali Rohár <pali@xxxxxxxxxx> wrote: > > On Monday 20 September 2021 14:14:16 Arnd Bergmann wrote: > > > From: Arnd Bergmann <arnd@xxxxxxxx> > > > > > > When procfs is disabled > > > > ... then the i8k_init_procfs function should not be called as the > > purpose of I8K code / config option is to export functionality over > > procfs. So when procfs is disabled then this i8k is noop. > > > > Patch which do not allow compilation of I8K when procfs is not enabled > > is pending here: > > > > https://lore.kernel.org/linux-hwmon/20210910071921.16777-1-rdunlap@xxxxxxxxxxxxx/ > > > > Ideally please test or review it. As you are not the first one who > > spotted -Werror problems with i8k and tried to workaround it. > > Ok, I'm now using that version in my randconfig tree, it looks sensible > and it addresses another problem. I'll let you know if something else > comes up with that patch applied, but I'm sure it fixes the issue > I reported. Feel free to add > > Reported-by: Arnd Bergmann <arnd@xxxxxxxx> > Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx> > > to Randy's patch if you like. > You'd have to reply to the patch. This is in x86 world and I can not apply it, or at least not without Ack from an x86 maintainer. They went ballistic on me once for doing that, and I won't do it again. Guenter
