Re: [PATCH] hwmon: (dell-smm) Don't build the proc interface if there's no /proc

[Guenter Roeck <linux@xxxxxxxxxxxx>]

On 9/15/21 6:47 AM, Adam Borowski wrote:
> Signed-off-by: Adam Borowski <kilobyte@xxxxxxxxxx>
> ---
>   drivers/hwmon/dell-smm-hwmon.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 774c1b0715d9..f381dfe1b427 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -403,7 +403,7 @@ static int __init i8k_get_dell_signature(int req_fn)
>   	return regs.eax == 1145651527 && regs.edx == 1145392204 ? 0 : -1;
>   }
>   
> -#if IS_ENABLED(CONFIG_I8K)
> +#if IS_ENABLED(CONFIG_I8K) && IS_ENABLED(CONFIG_PROCFS)
>   

This should be expressed as Kconfig dependency: I8K should depend on PROCFS.
Otherwise the configuration flag is misleading.

Guenter