On Thu, Sep 09, 2021 at 12:36:03AM +0300, Denis Pauk wrote: > Use superio function pointers in nct6775_sio_data instead direct calls. > > v2: split changes to separate patches > Link: https://bugzilla.kernel.org/show_bug.cgi?id=204807 > Signed-off-by: Denis Pauk <pauk.denis@xxxxxxxxx> Similar comments as per patch 1. ... > + void (*outb)(struct nct6775_sio_data *sio_data, int reg, int val); > + int (*inb)(struct nct6775_sio_data *sio_data, int reg); This part should be split separately and actually be a part of patch 1. ... > -static inline void > +static void > superio_outb(struct nct6775_sio_data *sio_data, int reg, int val) I guess it's one line and it should be a part of patch 1. ... > -static inline int > +static int > superio_inb(struct nct6775_sio_data *sio_data, int reg) Ditto. -- With Best Regards, Andy Shevchenko
