On Mon, 2021-08-30 at 08:34 -0700, Guenter Roeck wrote:
> On 8/30/21 6:50 AM, Eddie James wrote:
> > On Sat, 2021-08-28 at 08:52 -0700, Guenter Roeck wrote:
> > > On Fri, Aug 27, 2021 at 11:04:33PM +0000, Brandon Wyman wrote:
> > > > The bytes for max_power_out from the ibm-cffps devices do not
> > > > need
> > > > to be
> > > > swapped.
> > > >
> > > > Signed-off-by: Brandon Wyman <bjwyman@xxxxxxxxx>
> > >
> > > Eddie, can you confirm this ?
> >
> > This can't be true for all the power supplies supported by this
> > driver,
> > no. I think we need to check the version first. Brandon, I tested
> > this
> > on witherspoon (which is psu version 1) and get 3148 watts. If it's
> > not
> > swapped, that would be 19468 watts...
> >
>
> Hmm. Eddie, can you also have a look at commit 9fed8fa99334 ("hwmon:
> (pmbus/ibm-cffps) Fix write bits for LED control") ?
> We need to make sure that it doesn't mess up some versions of this
> PS.
That one looks correct to me. I believe older PSUs didn't enforce this
so I didn't catch it, but I do see that the older specifications
mention setting bit 6 to "allow write".
Thanks,
Eddie
>
> Thanks,
> Guenter
