> -----Original Message----- > From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter > Roeck > Sent: Saturday, July 17, 2021 7:25 PM > To: Sa, Nuno <Nuno.Sa@xxxxxxxxxx> > Cc: linux-hwmon@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Rob > Herring <robh+dt@xxxxxxxxxx>; Jean Delvare <jdelvare@xxxxxxxx> > Subject: Re: [RFC PATCH 1/6] hwmon: axi-fan-control: make sure the > clock is enabled > > > On Thu, Jul 08, 2021 at 02:01:06PM +0200, Nuno Sá wrote: > > The core will only work if it's clock is enabled. This patch is a > > minor enhancement to make sure that's the case. > > > > Signed-off-by: Nuno Sá <nuno.sa@xxxxxxxxxx> > > Can I apply this patch as well as patches 4/6 and 5/6 as-is, or > do they depend on patches 2/6 and 3/6 ? > > Thanks, > Guenter I think patch 5/6 only makes sense with patch 2/6. If we do not set the tacho evaluation parameters, clearing the fan fault irq has no effect... - Nuno Sá