Re: [PATCH] hwmon: nct6775: Add missing voltage reading NCT6796D

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Op wo 14 jul. 2021 om 17:26 schreef Guenter Roeck <linux@xxxxxxxxxxxx>:
>
> On 7/14/21 7:28 AM, Henk wrote:
> > Can you be more specific?
> >
>
> Not a single one of your patch submissions followed the guidelines in
> Documentation/process/submitting-patches.rst. Most common violations are:
>
> - No or insufficient patch description
>    See 'Describe your changes'
> - Patch sent as attachment
>    See 'No MIME, no links, no compression, no attachments.  Just plain text'
> - Instead of sending a patch, sent pointer to github location
>
> You could just set up git send-email and use it to send your patches,
> as suggested in submitting-patches.rst. Not doing that has cost both
> of us a lot of time, for no good reason. I don't know about your time,
> but I am not getting paid for my work as Linux kernel maintainer,
> and my time is limited.
>
> You for sure have accomplished one thing: A new formletter.
>
> <Formletter>
> Please follow the guidelines in
>      Documentation/hwmon/submitting-patches.rst
>      Documentation/process/submitting-patches.rst
> when submitting patches into the hardware monitoring subsystem.
> Patches not following those guidelines will be ignored.
> </Formletter>
>
> Guenter
>
Hi Guenter,

I am in similar position as you, my Linux work is unpaid and voluntary
and not subsidized as some of the other contributions are.

I am extremely grateful of the work that maintainers do and apologize
for the inconvenience that I may have caused.
Also I wish to thank you for the new form letter. I would have send a
pointer to my github location at first impulse however:

I forked torvalds/linux from github in the understanding that it would
allow me to create a proper documented pull request that could be
routed trough the proper channels.
However then i discovered after patching the file that I was not
allowed to create a pull request, which is quite annoying.
So I am looping in the Linuxfoundation in this mail in order to ask
them to please reconsider their current policy and allow the creation
of pull requests on gitgub/torvalds/linux . This would greatly reduce
the amount of overhead.
I would also argue that the github commenting system, the automated
build system, and the review system are quite good, and we have
definitely made some progress in that area since the invention of the
mailing-list.

I understand the master repositories should reside on kernel.org but
bringing in some of the feedback to the kernel via github could be
quite beneficial!

(Just occurred to me I can send a pointer to my own commit :
https://github.com/hvegh/linux/commit/00b3427269f731becbc10e9fe92046a6ad91eee8
 )


Kind regards,
Henk Vergonet




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux