Re: [PATCH v5] hwmon: (pmbus) Add support for MPS MP2949A

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/24/21 6:17 AM, Guenter Roeck wrote:
On Wed, Jun 23, 2021 at 08:54:26AM +0800, ainux.wang@xxxxxxxxx wrote:
From: "Ainux.Wang" <ainux.wang@xxxxxxxxx>

Add support for MP2949A device from Monolithic Power Systems, Inc. (MPS).
This is a triple-loop, digital, multi-phase controller.
This device:
- Supports up to three power rail.
- Provides 6 pulse-width modulations (PWMs), and can be configured up
   to 6-phase operation for Rail A , up to 2-phase operation for Rail B
   and up to 1-phase operation for Rail C.
- The PMBus registers are distributed into three pages: Page 0, Page 1,
   Page 2. Page 0 contains the registers for Rail A and most of the common
   settings for all of the rails. Page 1 contains register information for
   Rail B. Page 2 contains register information for Rail C.
- The MP2949A supports both 5mV VID step and 10mv VID step for IMVP8 and
   IMVP9.

Signed-off-by: Ainux.Wang <ainux.wang@xxxxxxxxx>
---
v5:
- Moved change log to right here.
v4:
- Removed mp2949a_read_byte_data().

Your other question left me confused. I had previously asked to provide
a rationale for filtering out the PMBUS_VOUT_MODE command, and I had
stated that "the chip does not support it" is not a valid reason. However,
"the chip does not support it but does not report an error when reading
it" _is_ a valid reason. So what happens when the PMBus core reads
PMBUS_VOUT_MODE ? Does the chip return an error, or some random data ?


Still waiting for a reply.

Guenter




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux