Re: [PATCH] hwmon: (pmbus/dps920ab) Delete some dead code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 18, 2021 at 04:46:01PM +0300, Dan Carpenter wrote:
> The debugfs_create_dir() function returns error pointers, it doesn't
> return NULL.  But debugfs functions don't need to be checked in normal
> situations and we can just delete this code.
> 
> Fixes: 1f442e213ce5 ("hwmon: (pmbus) Add driver for Delta DPS-920AB PSU")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/pmbus/dps920ab.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/hwmon/pmbus/dps920ab.c b/drivers/hwmon/pmbus/dps920ab.c
> index bd2df2a3c8e3..d3941f6eb29a 100644
> --- a/drivers/hwmon/pmbus/dps920ab.c
> +++ b/drivers/hwmon/pmbus/dps920ab.c
> @@ -119,8 +119,6 @@ static void dps920ab_init_debugfs(struct dps920ab_data *data, struct i2c_client
>  		return;
>  
>  	debugfs_dir = debugfs_create_dir(client->name, root);
> -	if (!debugfs_dir)
> -		return;
>  
>  	debugfs_create_file("mfr_id",
>  			    0400,
> -- 
> 2.30.2
> 



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux