On 13/05/21 11:33 am, Guenter Roeck wrote:
> When converting the driver to use the devm_hwmon_device_register_with_info
> API, the wrong register was selected when writing into inX_max attributes.
> Fix it.
>
> Fixes: 124b7e34a5a6 ("hwmon: (adm9240) Convert to devm_hwmon_device_register_with_info API")
> Reported-by: Chris Packham <Chris.Packham@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Works for me.
Tested-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/hwmon/adm9240.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/adm9240.c b/drivers/hwmon/adm9240.c
> index 5677263bcf0d..483cd757abd3 100644
> --- a/drivers/hwmon/adm9240.c
> +++ b/drivers/hwmon/adm9240.c
> @@ -485,7 +485,7 @@ static int adm9240_in_write(struct device *dev, u32 attr, int channel, long val)
> reg = ADM9240_REG_IN_MIN(channel);
> break;
> case hwmon_in_max:
> - reg = ADM9240_REG_IN(channel);
> + reg = ADM9240_REG_IN_MAX(channel);
> break;
> default:
> return -EOPNOTSUPP;
