Hi, On 5/8/21 3:14 PM, W_Armin@xxxxxx wrote: > From: Armin Wolf <W_Armin@xxxxxx> > > Since it was requested to use devres for the watchdog device, > use devm_watchdog_register() for watchdog registration and do > some small cleanups. > > Also use platform_device_register_simple() in sch56xx_device_add(). > > Tested on a Fujitsu Esprimo P720. > > v2: > - drop sch5627_remove() > - make sch56xx_watchdog_register() return void Thanks, series (still) looks good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> For the series. Regards, Hans p.s. For your next series when I give my Reviewed-by for v1 and there are some small changes which require a v2, feel free to add the Reviewed-by to the v2 series. > > Armin Wolf (4): > hwmon: (sch56xx) Use devres functions for watchdog > hwmon: (sch56xx-common) Use strscpy > hwmon: (sch56xx-common) Use helper function > hwmon: (sch56xx-common) Simplify sch56xx_device_add > > drivers/hwmon/sch5627.c | 18 ++-------- > drivers/hwmon/sch5636.c | 9 ++--- > drivers/hwmon/sch56xx-common.c | 65 ++++++++++------------------------ > drivers/hwmon/sch56xx-common.h | 4 +-- > 4 files changed, 25 insertions(+), 71 deletions(-) > > -- > 2.20.1 >
