On 06.05.2021 04:04, Guenter Roeck wrote: > On 5/5/21 1:12 PM, Bernhard Seibold wrote: >> Support accessing the chip via Asus WMI. This enables the driver to work >> on boards where the IO region is reserved by ACPI. >> >> Signed-off-by: Bernhard Seibold <mail@xxxxxxxxxxxxxxxxxxx> >> Tested-by: Artem S. Tashkinov <aros@xxxxxxx> > > No, this makes the driver unmaintainable. There should be a separate > driver which only makes WMI/ACPI accesses for everything. > > Guenter > I'm not sure what exactly you are suggesting. I assume your suggestion isn't to duplicate 5000 lines of code in order to avoid having 100 lines of ifdef'ed code?
