st 14. 4. 2021 v 5:29 odesílatel Guenter Roeck <linux@xxxxxxxxxxxx> napsal: > > On Wed, Apr 14, 2021 at 02:13:06AM +0200, Václav Kubernát wrote: > > This patch adds support for these devices: > > - YH-5151E - the PDU > > - YM-2151E - the PSU > > > > The device datasheet says that the devices support PMBus 1.2, but in my > > testing, a lot of the commands aren't supported and if they are, they > > sometimes behave strangely or inconsistently. For example, writes to the > > PAGE command requires using PEC, otherwise the write won't work and the > > page won't switch, even though, the standard says that PEC is optional. > > On the other hand, writes to SMBALERT don't require PEC. Because of > > this, the driver is mostly reverse engineered with the help of a tool > > called pmbus_peek written by David Brownell (and later adopted by my > > colleague Jan Kundrát). > > > > The device also has some sort of a timing issue when switching pages, > > which is explained further in the code. > > > > Because of this, the driver support is limited. It exposes only the > > values, that have been tested to work correctly. > > > > Signed-off-by: Václav Kubernát <kubernat@xxxxxxxxx> > > checkpatch says: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > #108: FILE: Documentation/hwmon/fsp-3y.rst:1: > +Kernel driver fsp3y > > WARNING: line length of 137 exceeds 100 columns > #409: FILE: drivers/hwmon/pmbus/fsp-3y.c:225: > + dev_warn(&client->dev, "Device mismatch: Configured %s (%d), detected %d\n", id->name, (int)id->driver_data, data->chip); > > Please fix and resubmit. > Done. Václav > Thanks, > Guenter
