On Fri, Apr 02, 2021 at 03:19:40PM +0200, zlukwins wrote: > Hi, > > > I am OpenBMC FW developer. We have a use cases which require PSU devices > energy counters reading. Looks like hwmon:pmbus does not support that right > now. > > Hwmon sysfs (https://www.kernel.org/doc/Documentation/hwmon/sysfs-interface) > already supports energy counter (energy[1-*]_input). > > PMBus standard (revision 1.3.1) provides API for getting energy - > READ_EIN/READ_EOUT commands. > > So I am wondering whether we could just add this implementation to the > hwmon/pmbus/pmbus_core.c? Or maybe there are some constraints? > Sure, go ahead. The only reason for not implementing it was that I did not have access to a chip supporting it when I wrote the code. Guenter