On 3/21/21 2:39 AM, Vadim Pasternak wrote: > > >> -----Original Message----- >> From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck >> Sent: Friday, March 19, 2021 11:36 PM >> To: Vadim Pasternak <vadimp@xxxxxxxxxx> >> Cc: linux-hwmon@xxxxxxxxxxxxxxx >> Subject: Re: [Re-send PATCH hwmon-next v2 1/1] hwmon: (mlxreg-fan) Add >> support for fan drawers capability and present registers >> >> On 3/16/21 5:02 AM, Vadim Pasternak wrote: >>> Add support for fan drawer's capability and present registers in order >>> to set mapping between the fan drawers and tachometers. Some systems >>> are equipped with fan drawers with one tachometer inside. Others with >>> fan drawers with several tachometers inside. Using present register >>> along with tachometer-to-drawer mapping allows to skip reading missed >>> tachometers and expose input for them as zero, instead of exposing >>> fault code returned by hardware. >>> >>> Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxx> >> >> I had asked for a number of changes to v2. Resending v2 without addressing >> anything isn't really helpful. > > Hi Guenter, > > I am sorry, I missed the change related to your comment: > "The outer double (( )) is pointless.". > I'll fix it. > > I think I handled your other comments or I am wrong? > None of the comments I sent as response to the original v2 have been addressed. > Should I send patch as v3 or as v2? > Any change requires a new version. Guenter > Thanks, > Vadim. > >> >> Guenter
