On 3/15/21 8:30 PM, Chris Packham wrote: > > On 16/03/21 3:35 pm, Chris Packham wrote: >> The BPA-RS600 is a compact 600W AC to DC removable power supply module. >> >> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> >> >> +static const struct of_device_id __maybe_unused bpa_rs600_of_match[] = { >> + { .compatible = "blutek,bpa-rs600" }, >> + {}, >> +}; > > I see this will fall foul of the name check in > __hwmon_device_register(). How should I name things to avoid this? > It isn't the binding. The driver name should not have a '-' in it. You could just name it bpa_rs600 instead. Guenter