On Mon, 2021-02-22 at 07:46 -0800, Guenter Roeck wrote: > On 2/22/21 7:12 AM, Romain Perier wrote: > > The strlcpy() reads the entire source buffer first, it is dangerous if > > the source buffer lenght is unbounded or possibility non NULL-terminated. > > length > > > It can lead to linear read overflows, crashes, etc... > > > Not here. This description is misleading. > > > As recommended in the deprecated interfaces [1], it should be replaced > > by strscpy. > > > > This commit replaces all calls to strlcpy that handle the return values > > by the corresponding strscpy calls with new handling of the return > > values (as it is quite different between the two functions). > > > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > > > > Signed-off-by: Romain Perier <romain.perier@xxxxxxxxx> > > This patch just adds pain to injury, as the source 'buffers' are all fixed > strings and their length will never exceed the maximum buffer length. > I really don't see the point of using strscpy() in this situation. Might as well just use strcpy (I'd still prefer stracpy) https://lore.kernel.org/lkml/24bb53c57767c1c2a8f266c305a670f7@xxxxxxx/T/
