[hwmon:hwmon-next 25/25] drivers/hwmon/pmbus/max31785.c:361:16: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 's64' {aka 'long long int'}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
head:   c52533beaf2853858ac4bc0db8d5aba04b5ab99f
commit: c52533beaf2853858ac4bc0db8d5aba04b5ab99f [25/25] hwmon: (pmbus/max31785) Support revision "B"
config: i386-randconfig-s002-20210201 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-215-g0fb77bb6-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?id=c52533beaf2853858ac4bc0db8d5aba04b5ab99f
        git remote add hwmon https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
        git fetch --no-tags hwmon hwmon-next
        git checkout c52533beaf2853858ac4bc0db8d5aba04b5ab99f
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/acpi.h:15,
                    from include/linux/i2c.h:13,
                    from drivers/hwmon/pmbus/max31785.c:10:
   drivers/hwmon/pmbus/max31785.c: In function 'max31785_probe':
>> drivers/hwmon/pmbus/max31785.c:361:16: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 's64' {aka 'long long int'} [-Wformat=]
     361 |   dev_err(dev, "Unrecognized MAX31785 revision: %x\n", ret);
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
      19 | #define dev_fmt(fmt) fmt
         |                      ^~~
   drivers/hwmon/pmbus/max31785.c:361:3: note: in expansion of macro 'dev_err'
     361 |   dev_err(dev, "Unrecognized MAX31785 revision: %x\n", ret);
         |   ^~~~~~~
   drivers/hwmon/pmbus/max31785.c:361:50: note: format string is defined here
     361 |   dev_err(dev, "Unrecognized MAX31785 revision: %x\n", ret);
         |                                                 ~^
         |                                                  |
         |                                                  unsigned int
         |                                                 %llx


vim +361 drivers/hwmon/pmbus/max31785.c

   327	
   328	static int max31785_probe(struct i2c_client *client)
   329	{
   330		struct device *dev = &client->dev;
   331		struct pmbus_driver_info *info;
   332		bool dual_tach = false;
   333		s64 ret;
   334	
   335		if (!i2c_check_functionality(client->adapter,
   336					     I2C_FUNC_SMBUS_BYTE_DATA |
   337					     I2C_FUNC_SMBUS_WORD_DATA))
   338			return -ENODEV;
   339	
   340		info = devm_kzalloc(dev, sizeof(struct pmbus_driver_info), GFP_KERNEL);
   341		if (!info)
   342			return -ENOMEM;
   343	
   344		*info = max31785_info;
   345	
   346		ret = i2c_smbus_write_byte_data(client, PMBUS_PAGE, 255);
   347		if (ret < 0)
   348			return ret;
   349	
   350		ret = i2c_smbus_read_word_data(client, MFR_REVISION);
   351		if (ret < 0)
   352			return ret;
   353	
   354		if (ret == MAX31785A || ret == MAX31785B) {
   355			dual_tach = true;
   356		} else if (ret == MAX31785) {
   357			if (!strcmp("max31785a", client->name) ||
   358			    !strcmp("max31785b", client->name))
   359				dev_warn(dev, "Expected max31785a/b, found max31785: cannot provide secondary tachometer readings\n");
   360		} else {
 > 361			dev_err(dev, "Unrecognized MAX31785 revision: %x\n", ret);
   362			return -ENODEV;
   363		}
   364	
   365		if (dual_tach) {
   366			ret = max31785_configure_dual_tach(client, info);
   367			if (ret < 0)
   368				return ret;
   369		}
   370	
   371		return pmbus_do_probe(client, info);
   372	}
   373	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux