Hi Kernel test robot, The 01/13/2021 17:48, kernel test robot wrote: > Hi Troy, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on hwmon/hwmon-next] > [also build test WARNING on joel-aspeed/for-next v5.11-rc3 next-20210113] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Troy-Lee/hwmon-aspeed2600-pwm-tacho-Add-driver-support/20210113-151325 > base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next > config: sparc-randconfig-r021-20210113 (attached as .config) > compiler: sparc-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/19a51124badf28349d26657b611da77d5dfba2f1 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Troy-Lee/hwmon-aspeed2600-pwm-tacho-Add-driver-support/20210113-151325 > git checkout 19a51124badf28349d26657b611da77d5dfba2f1 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > > >> drivers/hwmon/aspeed2600-pwm-tacho.c:581:5: warning: no previous prototype for 'aspeed_pwm_tacho_read' [-Wmissing-prototypes] > 581 | int aspeed_pwm_tacho_read(struct device *dev, enum hwmon_sensor_types type, > | ^~~~~~~~~~~~~~~~~~~~~ > >> drivers/hwmon/aspeed2600-pwm-tacho.c:615:5: warning: no previous prototype for 'aspeed_pwm_tacho_write' [-Wmissing-prototypes] > 615 | int aspeed_pwm_tacho_write(struct device *dev, enum hwmon_sensor_types type, > | ^~~~~~~~~~~~~~~~~~~~~~ Good catch, I'll fix it in v3 patch set. > > > vim +/aspeed_pwm_tacho_read +581 drivers/hwmon/aspeed2600-pwm-tacho.c > > 580 > > 581 int aspeed_pwm_tacho_read(struct device *dev, enum hwmon_sensor_types type, > 582 u32 attr, int channel, long *val) > 583 { > 584 struct aspeed_pwm_tachometer_data *priv = dev_get_drvdata(dev); > 585 long rpm; > 586 > 587 switch (type) { > 588 case hwmon_pwm: > 589 switch (attr) { > 590 case hwmon_pwm_input: > 591 *val = priv->pwm_channel[channel].falling; > 592 break; > 593 default: > 594 return -EOPNOTSUPP; > 595 } > 596 break; > 597 case hwmon_fan: > 598 switch (attr) { > 599 case hwmon_fan_input: > 600 rpm = aspeed_get_fan_tach_ch_rpm(dev, priv, channel); > 601 if (rpm < 0) > 602 return rpm; > 603 *val = rpm; > 604 break; > 605 default: > 606 return -EOPNOTSUPP; > 607 } > 608 break; > 609 default: > 610 return -EOPNOTSUPP; > 611 } > 612 return 0; > 613 } > 614 > > 615 int aspeed_pwm_tacho_write(struct device *dev, enum hwmon_sensor_types type, > 616 u32 attr, int channel, long val) > 617 { > 618 switch (type) { > 619 case hwmon_pwm: > 620 switch (attr) { > 621 case hwmon_pwm_input: > 622 return set_pwm(dev, channel, val); > 623 default: > 624 return -EOPNOTSUPP; > 625 } > 626 break; > 627 default: > 628 return -EOPNOTSUPP; > 629 } > 630 return -EOPNOTSUPP; > 631 } > 632 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Thanks, Troy Lee
