On Mon, 4 Jan 2021 at 02:05, Tian Tao <tiantao6@xxxxxxxxxxxxx> wrote:
>
> fixed the following coccicheck:
> drivers/hwmon/aspeed-pwm-tacho.c:634:60-61: WARNING opportunity for
> kobj_to_dev()
> drivers/hwmon/aspeed-pwm-tacho.c:623:60-61: WARNING opportunity for
> kobj_to_dev()
>
> Signed-off-by: Tian Tao <tiantao6@xxxxxxxxxxxxx>
Acked-by: Joel Stanley <joel@xxxxxxxxx>
> ---
> drivers/hwmon/aspeed-pwm-tacho.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c
> index 3d8239f..3cb88d6 100644
> --- a/drivers/hwmon/aspeed-pwm-tacho.c
> +++ b/drivers/hwmon/aspeed-pwm-tacho.c
> @@ -620,7 +620,7 @@ static ssize_t rpm_show(struct device *dev, struct device_attribute *attr,
> static umode_t pwm_is_visible(struct kobject *kobj,
> struct attribute *a, int index)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct aspeed_pwm_tacho_data *priv = dev_get_drvdata(dev);
>
> if (!priv->pwm_present[index])
> @@ -631,7 +631,7 @@ static umode_t pwm_is_visible(struct kobject *kobj,
> static umode_t fan_dev_is_visible(struct kobject *kobj,
> struct attribute *a, int index)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct aspeed_pwm_tacho_data *priv = dev_get_drvdata(dev);
>
> if (!priv->fan_tach_present[index])
> --
> 2.7.4
>
