On Wed, Dec 23, 2020 at 10:13:19PM +0100, Linus Walleij wrote: > This deletes the ABx500 hwmon driver, the only supported > variant being the AB8500. > > This driver has been replaced by generic frameworks. By > inspecting the abx500 sysfs files we see that it contains > things such as temp1_max, temp1_max_alarm, temp1_max_hyst, > temp1_max_hyst_alarm, temp1_min, temp1_min_alarm. > > It becomes obvious that the abx500.c is a reimplementation > of thermal zones. This is not very strange as the generic > thermal zones were not invented when this driver was merged > so people were rolling their own. > > The ab8500.c driver contains conversion tables for handling > a thermistor on ADC channels AUX1 and AUX2. > > I managed to replace the functionality of the driver with: > > - Activation of the ntc_thermistor.c driver, > CONFIG_SENSORS_NTC_THERMISTOR > - Activation of thermal zones, CONFIG_THERMAL > - In the device tree, connecting the NTC driver to the > processed IIO channels from the AB8500 GPADC ADC forming > two instances of NTC sensors. > - Connecting the two NTC sensors to a "chassis" thermal zone > in the device tree and setting that to hit the CPU frequency > at 50 degrees celsius and do a critical shutdown at 70 > degrees celsius, deploying a policy using the sensors. > > After talking to the original authors we concluded that the > driver was never properly parameterized in production so > what we now have in the device tree is already puts the > thermistors to better use than what the hwmon driver did. > > The two remaining channels for two battery temperatures is > already handled in the charging algorithms but can be > optionally extended to thermal zones as well if we want > these to trigger critical shutdown for the platform. > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > ChangeLog v1->v2: > - Also drop the Kconfig and Makefile entries. I was > sloppy and didn't commit all changes in my tree. Looks like my response didn't make it to the list. Sigh. Continuously struggling with e-mail servers believing that I am a spammer. Anyway, I applied v1 and fixed everything up there (Makefile, Kconfig, and removed documentation). No need to resend. Thanks, Guenter
