On Mon, Nov 30, 2020 at 03:46:19PM +0800, Charles wrote: > On 28/11/2020 上午12:10, Guenter Roeck wrote: > > On Fri, Nov 27, 2020 at 09:59:01AM +0800, Charles wrote: > > > Add the pmbus driver for the STMicroelectronics pm6764 voltage regulator. > > > > > > the output voltage use the MFR_READ_VOUT 0xD4 > > > vout value returned is linear11 > > > > > > Signed-off-by: Charles Hsu <hsu.yungteng@xxxxxxxxx> > > This patch (again) didn't make it to any of the mailing lists. > > Please try to find out why this is the case. I usually pick up > > patches from https://patchwork.kernel.org/project/linux-hwmon/list/, > > and may easily miss a patch if I can't find it there. > > > > > --- > > > > > > v5: > > > - Add MAINTAINERS > > > - Add a reference into trivial-devices.yaml > > > v4: > > > - Add pm6764tr to Documentation/hwmon/index.rst. > > > v3: > > > - Add Documentation(Documentation/hwmon/pm6764tr.rst). > > > - Fix include order. > > > v2: > > > - Fix formatting. > > > - Remove pmbus_do_remove. > > > - Change from .probe to .probe_new. > > > v1: > > > - Initial patchset. > > > > > > --- > > > > > > .../devicetree/bindings/trivial-devices.yaml | 2 + > > > Documentation/hwmon/index.rst | 1 + > > > Documentation/hwmon/pm6764tr.rst | 33 ++++++++ > > > MAINTAINERS | 7 ++ > > > drivers/hwmon/pmbus/Kconfig | 9 +++ > > > drivers/hwmon/pmbus/Makefile | 1 + > > > drivers/hwmon/pmbus/pm6764tr.c | 76 +++++++++++++++++++ > > > 7 files changed, 129 insertions(+) > > > create mode 100644 Documentation/hwmon/pm6764tr.rst > > > create mode 100644 drivers/hwmon/pmbus/pm6764tr.c > > > > > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > > > index ab623ba930d5..cdd7bdb6abbb 100644 > > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > > > @@ -348,6 +348,8 @@ properties: > > > - socionext,synquacer-tpm-mmio > > > # i2c serial eeprom (24cxx) > > > - st,24c256 > > > + # SMBus/I2C Voltage Regulator > > > + - st,pm6764tr > > > # Ambient Light Sensor with SMBUS/Two Wire Serial Interface > > > - taos,tsl2550 > > > # 8-Channels, 12-bit ADC > > This, like all devicetre changes, needs to be a separate patch. > > Also, please make sure to copy dt maintainers and the dt mailing list > > when you send that patch. > > > Thank you for your suggestions. > > I will send that patch as soon as possible. > > > > > diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst > > > index b797db738225..1bbd05e41de4 100644 > > > --- a/Documentation/hwmon/index.rst > > > +++ b/Documentation/hwmon/index.rst > > > @@ -144,6 +144,7 @@ Hardware Monitoring Kernel Drivers > > > pc87360 > > > pc87427 > > > pcf8591 > > > + pm6764tr > > > pmbus > > > powr1220 > > > pxe1610 > > > diff --git a/Documentation/hwmon/pm6764tr.rst b/Documentation/hwmon/pm6764tr.rst > > > new file mode 100644 > > > index 000000000000..5e8092e39297 > > > --- /dev/null > > > +++ b/Documentation/hwmon/pm6764tr.rst > > > @@ -0,0 +1,33 @@ > > > +.. SPDX-License-Identifier: GPL-2.0-only > > > + > > > +Kernel driver pm6764tr > > > +====================== > > > + > > > +Supported chips: > > > + > > > + * ST PM6764TR > > > + > > > + Prefix: 'pm6764tr' > > > + > > > + Addresses scanned: - > > > + > > > + Datasheet: http://www.st.com/resource/en/data_brief/pm6764.pdf > > > + > > > +Authors: > > > + <hsu.yungteng@xxxxxxxxx> > > > + > > > +Description: > > > +------------ > > > + > > > +This driver supports the STMicroelectronics PM6764TR chip. The PM6764TR is a high > > > +performance digital controller designed to power Intel’s VR12.5 processors and memories. > > > + > > Unrelated side note: I understand this means that you are forced to keep the > > datasheet under wraps, which in turn means I can not suggest functionality > > improvements since I don't have access to it. If the chip happens to support > > per-rail telemetry, you might want to consider adding support for that in a > > follow-up patch. > > > > > +The device utilizes digital technology to implement all control and power management > > > +functions to provide maximum flexibility and performance. The NVM is embedded to store > > > +custom configurations. The PM6764TR device features up to 4-phase programmable operation. > > > + > > > +The PM6764TR supports power state transitions featuring VFDE, and programmable DPM > > > +maintaining the best efficiency over all loading conditions without compromising transient > > > +response. The device assures fast and independent protectionagainstload overcurrent, > > "protectionagainstload" -> "protection against load" > > > > > +under/overvoltage and feedback disconnections. > > > + > > Drop empty line at end. > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 94ac10a153c7..a3fea132c4ed 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -13904,6 +13904,13 @@ M: Logan Gunthorpe <logang@xxxxxxxxxxxx> > > > S: Maintained > > > F: drivers/dma/plx_dma.c > > Add empty line. > > > There is an empty line here, > > Should I add one more empty line? > One empty line is needed. Maybe I missed it. I am looking forward to the next version of your patch; then we'll see. Thanks, Guenter
