On Thu, 26 Nov 2020 at 01:45, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > On Fri, Nov 13, 2020 at 03:08:51PM +0000, Paul Barker wrote: > > Instead of implementing an is_visible function we can dynamically > > populate the attribute group for the device based on whether a fan > > tachometer input is configured or not. > > > > Signed-off-by: Paul Barker <pbarker@xxxxxxxxxxxx> > > This will make it more difficult to ever convert the driver to use the > devm_hwmon_device_register_with_info() API. I'd rather see a conversion > to that API now instead of making it more difficult to implement in the > future. Ah I hadn't realised that was the preferred API. I'll take a look and see if I can convert the driver, perhaps as a standalone patch so we can get this right before I re-work my implementation of multiple tachometer input support. Thanks, -- Paul Barker Konsulko Group
