On Wed, Oct 07, 2020 at 10:51:48AM +0300, Dan Carpenter wrote: > This code works okay but Smatch flagged it as a double free. I've > changed three things to make it more clear. 1) Remove the call to > free_capabilities() in acpi_power_meter_add(). This call is a no-op > because the capabilities have not been allocated yet. 2) Set "*str" to > NULL in free_capabilities() so that way the function can be called twice > in a row without leading to a double free. 3) Call free_capabilities() > in read_capabilities() instead of open coding the free. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Hmm, somehow this patch slipped throigh the cracks. Sorry for that. Applied. Thanks, Guenter