On Fri, Oct 02, 2020 at 09:11:35PM +0300, Andy Shevchenko wrote: > On Fri, Oct 02, 2020 at 03:04:27PM +0800, Rahul Tanwar wrote: ... > > + case hwmon_in: > > + if (attr == hwmon_in_input) > > + return 0444; > > > + return 0; > > > + default: > > > + return 0; > > break here and > > > + } > > return 0; here only once. This probably makes little sense. -- With Best Regards, Andy Shevchenko