* Dan Carpenter (dan.carpenter@xxxxxxxxxx) wrote:
> Smatch has a new check for resource leaks which found a bug in probe:
>
> drivers/hwmon/w83627ehf.c:2417 w83627ehf_probe()
> warn: 'res->start' not released on lines: 2412.
>
> We need to clean up if devm_hwmon_device_register_with_info() fails.
>
> Fixes: 266cd5835947 ("hwmon: (w83627ehf) convert to with_info interface")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Yeh that looks right to me; thanks!
Reviewed-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> ---
> drivers/hwmon/w83627ehf.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
> index 5a5120121e50..3964ceab2817 100644
> --- a/drivers/hwmon/w83627ehf.c
> +++ b/drivers/hwmon/w83627ehf.c
> @@ -1951,8 +1951,12 @@ static int w83627ehf_probe(struct platform_device *pdev)
> data,
> &w83627ehf_chip_info,
> w83627ehf_groups);
> + if (IS_ERR(hwmon_dev)) {
> + err = PTR_ERR(hwmon_dev);
> + goto exit_release;
> + }
>
> - return PTR_ERR_OR_ZERO(hwmon_dev);
> + return 0;
>
> exit_release:
> release_region(res->start, IOREGION_LENGTH);
> --
> 2.28.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
