Re: [PATCH 0/3] Extending hwmon ABI with attributes for rated values

zlukwins <zbigniew.lukwinski@xxxxxxxxxxxxxxx> · Mon, 10 Aug 2020 07:39:23 +0200

On 8/7/20 5:52 PM, Guenter Roeck wrote:
On 7/31/20 12:37 PM, Zbigniew Lukwinski wrote:
This patch series is about extending hwmon ABI with new attributes
for rated values. All of that is to cover PMBus specification which
provides registers reporting rated values:
PMBus Power System Mgt Protocol Specification - Part II – Revision 1.3.1,
chapters: 22.3.1 - 22.3.10, 22.3.15

Zbigniew Lukwinski (3):
   docs: hwmon: Add attributes to report rated values
   hwmon: (core) Add support for rated attributes
   hwmon: (pmbus/core) Add support for rated attributes

  Documentation/hwmon/pmbus.rst           | 15 ++++++-
  Documentation/hwmon/sysfs-interface.rst | 70 +++++++++++++++++++++++++++++++++
  drivers/hwmon/hwmon.c                   | 10 +++++
  drivers/hwmon/pmbus/pmbus.h             | 13 ++++++
  drivers/hwmon/pmbus/pmbus_core.c        | 49 +++++++++++++++++++----
  include/linux/hwmon.h                   | 20 ++++++++++
  6 files changed, 168 insertions(+), 9 deletions(-)

I have been struggling with "rated_{min,max}" vs. "{min,max}_rated",
but then figured it does not really make a difference, and rated_ as
prefix may actually make more sense. I'll queue the series for v5.10.
Let's see if there is any feedback.

Thanks,
Guenter

Sure.

Thanks,

Zbigniew