On Wed, Jul 15, 2020 at 07:55:52AM -0700, Guenter Roeck wrote: > On 7/15/20 6:00 AM, Sudeep Holla wrote: > > On Wed, Jul 15, 2020 at 01:13:38PM +0100, Cristian Marussi wrote: > >> SMATCH detected a potential buffer overflow in the manipulation of > >> hwmon_attributes array inside the scmi_hwmon_probe function: > >> > >> drivers/hwmon/scmi-hwmon.c:226 > >> scmi_hwmon_probe() error: buffer overflow 'hwmon_attributes' 6 <= 9 > >> > >> Fix it by statically declaring the size of the array as the maximum > >> possible as defined by hwmon_max define. > >> > > > > Makes sense to me, > > > > Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxx> > > > > There may be other such instances. I am not sure if Guenter has ignored > > them intentionally or just no one has fixed them so far. > > I am not perfect. No, I have not intentionally ignored anything, > and I don't recall seeing smatch reports (or this patch) before. > Sorry, it was not complaint, it does sound so now when I read that again. What I meant is, not everyone likes to fix all the warnings from various tools and I was just asking if this falls into that category as the overflow can't happen if we use the standard hwmon_max enums as indicies. -- Regards, Sudeep
