On Sun, Jul 05, 2020 at 02:43:46PM +0000, Barnabás Pőcze wrote: > 2020. július 5., vasárnap 15:23 keltezéssel, Guenter Roeck írta: > > On 7/5/20 4:34 AM, Barnabás Pőcze wrote: > > [ ... ] > > > > > > > Furthermore, did it help answer the "who is going to maintain the driver after the initial submission" question of your previous email? > > > > > > > > A driver is not write-and-forget. It has to be maintained, preferably by someone > > > > with access to the hardware. Otherwise it is going to bit-rot. Do you plan to > > > > volunteer to do that ? > > > > > > I have no clue what that entails, but I am assuming: fixing bugs, accepting, reviewing patches for that driver, then forwarding them upstream, maybe also updating the code base according to the best practices at the moment from time to time, correct? > > > > You would not have to forward patches upstream (I see them anyway), but > > correct for the rest. > > > > I see, thank you for the clarification. > > > > > I would certainly volunteer if it is needed. > > > > That would be great. > > > > Something else that came to my mind: Did you examine the DSDT ? > > If the board vendor did the right thing, it should include an abstract > > means to read the fan data through ACPI. That would be much better than > > having to read it from the EC directly. > > > > Thanks, > > Guenter > > > I agree that it would be better, I tried this approach because the Control Center software provided for Microsoft Windows uses direct port i/o, so I didn't really put much thought into the possible existence of an ACPI method to get the data, I am not familiar with ACPI either. > > I did, at least I tried to examine the DSDT, but I could not really find anything fan related. Now I looked again, same results. Maybe it's that I don't know what exactly I should be looking for. And I feel like the acpi/fan driver should have picked it up, no? I could identify the EC, however. But I don't see anything relevant there, either. That's not to say there isn't, I just couldn't find it. > No worries; at least you tried. Interesting that Windows doesn't use ACPI; that is exactly what it is supposed to be used for, and Microsoft was involved in writing its specification. Oh well, it is what it is. Thanks, Guenter
