On Mon, Jun 01, 2020 at 10:53:57AM +0000, Ugur Usug wrote: > Hi Guenter, > We want to add new device specific functionalities to existing support with common pmbus.c on MAX20796. We want to cover some Maxim specific features and registers. We would like to take your suggestions on this? Could we create a separate pmbus/max20796.c file for this and retract the existing common support from pmbus.c? Yes, I guess so. Before you do that, though, it might make sense to let me know what you plan to do. Adding debugfs entries would be ok, but not setting any of the chip specific parameters (those should not be settable during runtime, at last not through sysfs / debugfs). Thanks, Guenter
