On 5/27/20 8:25 AM, Alexander Monakov wrote: > On Wed, 27 May 2020, Guenter Roeck wrote: > >>> In the current driver, the accumulation thread starts during the probe and the >>> prev_value of sockets and the core0 is updated with the current MSR value. >>> It takes (nr_cpus - 1) iterations of the thread to populate the prev_value for >>> the other cores. >>> >>> By populating prev_value of all the cores during probe, we can >>> certainly save some >>> information (values with in one wrap-around at the best). If this >>> information is >>> useful, i can submit a patch to do so. Guenter, could you suggest us on this. >>> >> >> As long as you don't ignore counter values from before loading the driver, >> sure, go ahead. > > Hm? If I'm understanding correctly what Naveen is proposing, that would simply > move reading the initial values ahead by a few hundred cycles (the latency to > start the thread). It wouldn't change anything about the issue, and make the > code more complicated :( > At this point the question is if I should drop this driver entirely. Guenter
