On Tue, May 12, 2020 at 09:38:06AM +0000, Amy.Shih@xxxxxxxxxxxxxxxx wrote:
> From: Amy Shih <amy.shih@xxxxxxxxxxxxxxxx>
>
> The format of temperature limitation registers are 8-bit 2's complement
> and the range is -128~127.
> Converts the reading value to signed char to fix the incorrect range
> of temperature limitation registers.
>
> Signed-off-by: Amy Shih <amy.shih@xxxxxxxxxxxxxxxx>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/nct7904.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
> index 6fb06f7..04f2a8e 100644
> --- a/drivers/hwmon/nct7904.c
> +++ b/drivers/hwmon/nct7904.c
> @@ -390,6 +390,7 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
> struct nct7904_data *data = dev_get_drvdata(dev);
> int ret, temp;
> unsigned int reg1, reg2, reg3;
> + s8 temps;
>
> switch (attr) {
> case hwmon_temp_input:
> @@ -495,7 +496,8 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
>
> if (ret < 0)
> return ret;
> - *val = ret * 1000;
> + temps = ret;
> + *val = temps * 1000;
> return 0;
> }
>
> --
> 1.8.3.1
>
