On 5/7/20 5:54 PM, Alex Qiu wrote: > Hi Guenter, > > The drivers look good on our system, although more tests are ongoing. > The patch LGTM with minor nit. Thank you very much! > > On Wed, May 6, 2020 at 2:49 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: >> >> MAX16601 is a VR13.HC Dual-Output Voltage Regulator Chipset, >> implementing a (8+1) multiphase synchronous buck converter. >> >> Cc: Alex Qiu <xqiu@xxxxxxxxxx> >> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> >> --- [ ... ] >> + >> +#define REG_SETPT_DVID 0xd1 >> +#define DAC_10MV_MODE BIT(4) >> +#define REG_PHASE_ID 0xf3 >> +#define CORE_RAIL_INDICATOR BIT(7) > > Maybe we can move the above two lines down, so the register addresses > become sequential in the source file. > Makes sense. Will do. Thanks, Guenter
