On Fri, Apr 17, 2020 at 11:28:53AM +0200, Sascha Hauer wrote: > The jc42 driver passes I2C client's name as hwmon device name. In case > of device tree probed devices this ends up being part of the compatible > string, "jc-42.4-temp". This name contains hyphens and the hwmon core > doesn't like this: > > jc42 2-0018: hwmon: 'jc-42.4-temp' is not a valid name attribute, please fix > > This changes the name to "jc42" which doesn't have any illegal > characters. > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> I have not heard a better suggestion, so applied. Thanks, Guenter > --- > drivers/hwmon/jc42.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c > index f2d81b0558e5..e3f1ebee7130 100644 > --- a/drivers/hwmon/jc42.c > +++ b/drivers/hwmon/jc42.c > @@ -506,7 +506,7 @@ static int jc42_probe(struct i2c_client *client, const struct i2c_device_id *id) > } > data->config = config; > > - hwmon_dev = devm_hwmon_device_register_with_info(dev, client->name, > + hwmon_dev = devm_hwmon_device_register_with_info(dev, "jc42", > data, &jc42_chip_info, > NULL); > return PTR_ERR_OR_ZERO(hwmon_dev);
