On Thu, 16 Jan 2020 at 14:18, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > This patch series implements various improvements for the k10temp driver. > > Patch 1/4 introduces the use of bit operations. > > Patch 2/4 converts the driver to use the devm_hwmon_device_register_with_info > API. This not only simplifies the code and reduces its size, it also > makes the code easier to maintain and enhance. > > Patch 3/4 adds support for reporting Core Complex Die (CCD) temperatures > on Ryzen 3 (Zen2) CPUs. > > Patch 4/4 adds support for reporting core and SoC current and voltage > information on Ryzen CPUs. > > k10temp-pci-00c3 > Adapter: PCI adapter > Vcore: +1.36 V > Vsoc: +1.18 V > Tdie: +86.8°C (high = +70.0°C) > Tctl: +86.8°C > Tccd1: +80.0°C > Tccd2: +81.8°C > Icore: +44.14 A > Isoc: +13.83 A > > The patch series has only been tested with Ryzen 3900 CPUs. Further test > coverage will be necessary before the changes can be applied to the Linux > kernel. I have some Zen1 and Zen1+ here. My Ryzen 3 1300X, applied to 5.5.0-rc5 machine idle, I thought at first the temperature may be a bit low, so I've added other reported temperatures. I now think it is maybe ok. k10temp-pci-00c3 Adapter: PCI adapter Vcore: +1.41 V Vsoc: +0.89 V Tdie: +21.2°C (high = +70.0°C) Tctl: +21.2°C Icore: +30.14 A Isoc: +8.66 A SYSTIN: +29.0°C (high = +0.0°C, hyst = +0.0°C) ALARM sensor = thermistor CPUTIN: +25.5°C (high = +80.0°C, hyst = +75.0°C) sensor = thermistor AUXTIN0: -1.5°C sensor = thermistor AUXTIN1: +87.0°C sensor = thermistor AUXTIN2: +23.0°C sensor = thermistor AUXTIN3: -27.0°C sensor = thermistor SMBUSMASTER 0: +20.5°C After about 2 minutes of make -j8 on kernel, to load it k10temp-pci-00c3 Adapter: PCI adapter Vcore: +1.26 V Vsoc: +0.89 V Tdie: +46.2°C (high = +70.0°C) Tctl: +46.2°C Icore: +45.73 A Isoc: +11.18 A SYSTIN: +29.0°C (high = +0.0°C, hyst = +0.0°C) ALARM sensor = thermistor CPUTIN: +38.5°C (high = +80.0°C, hyst = +75.0°C) sensor = thermistor AUXTIN0: -7.5°C sensor = thermistor AUXTIN1: +85.0°C sensor = thermistor AUXTIN2: +23.0°C sensor = thermistor AUXTIN3: -27.0°C sensor = thermistor SMBUSMASTER 0: +46.0°C So I guess the temperatures *are* in the right area. Interestingly, the Vcore restores to above +1.4V when idle. And my Ryzen 5 3400G (Zen+), applied to 5.4.12, box is idle, also showing the gpu measurements of this APU to confirm the temperature: k10temp-pci-00c3 Adapter: PCI adapter Vcore: +0.94 V Vsoc: +1.09 V Tdie: +34.8°C (high = +70.0°C) Tctl: +34.8°C Icore: +6.24 A Isoc: +8.30 A amdgpu-pci-0900 Adapter: PCI adapter vddgfx: N/A vddnb: N/A edge: +34.0°C (crit = +80.0°C, hyst = +0.0°C) For my Ryzen 5 2500u laptop (Zen1), again showing the gpu: k10temp-pci-00c3 Adapter: PCI adapter Vcore: +0.97 V Vsoc: +0.93 V Tdie: +37.2°C (high = +70.0°C) Tctl: +37.2°C Icore: +19.75 A Isoc: +8.66 A amdgpu-pci-0300 Adapter: PCI adapter vddgfx: N/A vddnb: N/A edge: +37.0°C (crit = +80.0°C, hyst = +0.0°C) Thanks. ĸen -- We hope and trust that our values and loyal customers will bear with us in the coming months as we interact synergistically with change management in our striving for excellence. That is our mission.
