Re: [PATCH v3 02/12] ACPI: thermal: switch to use <linux/units.h> helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 13, 2019 at 6:03 AM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:
> 2019年12月12日(木) 0:29 Andy Shevchenko <andy.shevchenko@xxxxxxxxx>:
> > On Wed, Dec 11, 2019 at 4:39 PM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:

> > >                         } else if (crt > 0) {
> > > -                               unsigned long crt_k = CELSIUS_TO_DECI_KELVIN(crt);
> > > +                               unsigned long crt_k =
> > > +                                       celsius_to_deci_kelvin(crt);
> >
> > It used to be one line, why do two?
>
> Because this line over 80 characters.  This patch doesn't make this line
> longer, but checkpatch.pl complains about it.

I'm not a maintainer here, but as it was before why not to leave as is
(in terms of line length)?
Supposedly maintainers are okay with it.

> > >         pr_info(PREFIX "%s [%s] (%ld C)\n", acpi_device_name(device),
> > > -               acpi_device_bid(device), DECI_KELVIN_TO_CELSIUS(tz->temperature));
> > > +               acpi_device_bid(device),
> > > +               deci_kelvin_to_celsius(tz->temperature));
> >
> > Ditto.
>
> Same as above, checkpatch.pl complains about line over 80 characters.

Same as above.

P.S. checkpatch is recommendation, and not something one must follow.

-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux