Hi Giovanni, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hwmon/hwmon-next] [also build test WARNING on v5.4-rc7 next-20191114] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Giovanni-Mascellani/hwmon-dell-smm-hwmon-Disable-BIOS-fan-control-on-SET_FAN/20191115-052315 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next config: i386-randconfig-h001-20191115 (attached as .config) compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): In file included from include/linux/ioport.h:13:0, from include/linux/device.h:15, from include/linux/node.h:18, from include/linux/cpu.h:17, from drivers/hwmon/dell-smm-hwmon.c:15: drivers/hwmon/dell-smm-hwmon.c: In function 'i8k_exit': drivers/hwmon/dell-smm-hwmon.c:1305:7: error: implicit declaration of function 'i8k_enable_bios' [-Werror=implicit-function-declaration] if (i8k_enable_bios()) ^ include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ >> drivers/hwmon/dell-smm-hwmon.c:1305:3: note: in expansion of macro 'if' if (i8k_enable_bios()) ^~ Cyclomatic Complexity 1 include/linux/err.h:PTR_ERR Cyclomatic Complexity 1 include/linux/percpu-defs.h:__this_cpu_preempt_check Cyclomatic Complexity 1 include/linux/dmi.h:dmi_check_system Cyclomatic Complexity 1 include/linux/dmi.h:dmi_get_system_info Cyclomatic Complexity 1 include/linux/dmi.h:dmi_first_match Cyclomatic Complexity 3 drivers/hwmon/dell-smm-hwmon.c:i8k_get_dmi_data Cyclomatic Complexity 1 drivers/hwmon/dell-smm-hwmon.c:i8k_init_procfs Cyclomatic Complexity 14 drivers/hwmon/dell-smm-hwmon.c:i8k_smm_func Cyclomatic Complexity 124 drivers/hwmon/dell-smm-hwmon.c:i8k_is_visible Cyclomatic Complexity 1 include/linux/cpu.h:get_online_cpus Cyclomatic Complexity 1 include/linux/cpu.h:put_online_cpus Cyclomatic Complexity 1 drivers/hwmon/dell-smm-hwmon.c:i8k_smm Cyclomatic Complexity 6 drivers/hwmon/dell-smm-hwmon.c:i8k_get_dell_signature Cyclomatic Complexity 5 drivers/hwmon/dell-smm-hwmon.c:i8k_get_fan_nominal_speed Cyclomatic Complexity 64 drivers/hwmon/dell-smm-hwmon.c:i8k_probe Cyclomatic Complexity 5 drivers/hwmon/dell-smm-hwmon.c:i8k_get_fan_speed Cyclomatic Complexity 2 drivers/hwmon/dell-smm-hwmon.c:_i8k_get_temp Cyclomatic Complexity 2 drivers/hwmon/dell-smm-hwmon.c:i8k_get_temp_type Cyclomatic Complexity 5 drivers/hwmon/dell-smm-hwmon.c:i8k_get_fan_status Cyclomatic Complexity 6 drivers/hwmon/dell-smm-hwmon.c:i8k_set_fan Cyclomatic Complexity 10 drivers/hwmon/dell-smm-hwmon.c:_i8k_get_fan_type Cyclomatic Complexity 4 drivers/hwmon/dell-smm-hwmon.c:i8k_get_fan_type Cyclomatic Complexity 1 include/linux/kernel.h:kstrtoul Cyclomatic Complexity 5 drivers/hwmon/dell-smm-hwmon.c:i8k_hwmon_pwm_store Cyclomatic Complexity 4 drivers/hwmon/dell-smm-hwmon.c:i8k_hwmon_pwm_show Cyclomatic Complexity 11 drivers/hwmon/dell-smm-hwmon.c:i8k_hwmon_fan_label_show Cyclomatic Complexity 4 drivers/hwmon/dell-smm-hwmon.c:i8k_hwmon_fan_show Cyclomatic Complexity 7 drivers/hwmon/dell-smm-hwmon.c:i8k_hwmon_temp_label_show Cyclomatic Complexity 7 drivers/hwmon/dell-smm-hwmon.c:i8k_get_temp Cyclomatic Complexity 4 drivers/hwmon/dell-smm-hwmon.c:i8k_hwmon_temp_show Cyclomatic Complexity 1 include/linux/err.h:IS_ERR Cyclomatic Complexity 51 drivers/hwmon/dell-smm-hwmon.c:i8k_init_hwmon Cyclomatic Complexity 6 drivers/hwmon/dell-smm-hwmon.c:i8k_init Cyclomatic Complexity 1 drivers/hwmon/dell-smm-hwmon.c:i8k_exit_procfs Cyclomatic Complexity 6 drivers/hwmon/dell-smm-hwmon.c:i8k_exit cc1: some warnings being treated as errors vim +/if +1305 drivers/hwmon/dell-smm-hwmon.c 1297 1298 static void __exit i8k_exit(void) 1299 { 1300 hwmon_device_unregister(i8k_hwmon_dev); 1301 i8k_exit_procfs(); 1302 1303 if (bios_disabled) { 1304 pr_warn("re-enabling BIOS fan control\n"); > 1305 if (i8k_enable_bios()) 1306 pr_warn("could not re-enable BIOS fan control\n"); 1307 } 1308 } 1309 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation
Attachment:
.config.gz
Description: application/gzip
