On Wed, Nov 13, 2019 at 12:00:22AM +0900, Akinobu Mita wrote: > 2019年11月12日(火) 23:21 Christoph Hellwig <hch@xxxxxx>: > > > > On Tue, Nov 12, 2019 at 11:19:46PM +0900, Akinobu Mita wrote: > > > OK. I'll add two macros. > > > > > > #define MILLICELSIUS_TO_KELVIN(t) ((t) / 1000 + 273) DIV_ROUND_CLOSEST() ? > > > #define KELVIN_TO_MILLICELSIUS(t) (((t) - 273) * 1000) > > > > Can you add them to linux/thermal.h that already has similar > > helpers? > > Should we add a new linux/temperature.h so that any other drivers or > subsystems (including thermal.h and hwmon.h) can use these macros? Good idea. I don't like the idea of pulling in all of linux/thermal.h just for the above macros. Guenter
