I have been using SENSORS_W83795_FANCTRL for several years and never had any problem. When the driver was added, I had not tested that part of the driver yet so I wanted to be super cautious, but time has shown that it works just fine. In the long run I even believe that we should drop the option and enable the feature unconditionally. It doesn't do anything until the user explicitly starts twiddling with sysfs attributes anyway. Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> --- drivers/hwmon/Kconfig | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) --- linux-5.2.orig/drivers/hwmon/Kconfig 2019-07-08 00:41:56.000000000 +0200 +++ linux-5.2/drivers/hwmon/Kconfig 2019-08-06 09:55:16.344547556 +0200 @@ -1834,17 +1834,12 @@ config SENSORS_W83795 will be called w83795. config SENSORS_W83795_FANCTRL - bool "Include automatic fan control support (DANGEROUS)" + bool "Include automatic fan control support" depends on SENSORS_W83795 help If you say yes here, support for automatic fan speed control will be included in the driver. - This part of the code wasn't carefully reviewed and tested yet, - so enabling this option is strongly discouraged on production - servers. Only developers and testers should enable it for the - time being. - Please also note that this option will create sysfs attribute files which may change in the future, so you shouldn't rely on them being stable. -- Jean Delvare SUSE L3 Support
